Rename Notebook #22
Merged
Rename Notebook #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e.g. different meaning of "import" and that not all data will be anonymized etc
cristianberneanu
approved these changes
Sep 28, 2022
edongashi
reviewed
Sep 29, 2022
| "Notebook": { | ||
| "AdminPanel": { |
There was a problem hiding this comment.
There's no need for active maintenance of this translation file. I would delete all GUI keys, keep developing the app, and finally extract all i18nMissingKeys from the chromium dev tools with console.log(JSON.stringify(window.i18nMissingKeys)). This is where the natural language keys shine, because you can keep viewing the English strings without having them written in the file.
There was a problem hiding this comment.
👍 let's leave it up to the discussion in #11 and either delete or proceed in a follow-up PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20
I've also spotted some wording inconsistent with the new workflow - in our new app the import happens at the last step, not first.
I also wasn't sure about the file naming convention using dashes
notebook-nav, but kept it.